Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Fix two JS errors by replacing sync XHR - #17299

Closed
pipboy96 wants to merge 10 commits into
EFForg:masterfrom
pipboy96:patch-11
Closed

pipboy96 wants to merge 10 commits into
EFForg:masterfrom
pipboy96:patch-11

Conversation

@pipboy96

@pipboy96 pipboy96 commented Jan 28, 2019 •

Copy link
Copy Markdown
Contributor

This PR fixes these errors:

  • Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user’s experience. For more help http://xhr.spec.whatwg.org/
  • XML Parsing Error: syntax error (This error is specific to Firefox)

Please test if this PR breaks anything before merging, even though it doesn't seem to.

@zoracon

zoracon commented Jan 29, 2019

Copy link
Copy Markdown
Contributor

@pipboy96 which environments have you tested on for FF? I'll pull and test this week before the release to make sure this pans out well enough

@pipboy96

Copy link
Copy Markdown
Contributor Author

@zoracon Firefox Nightly on Linux. I can also test on different versions of Firefox and also on Windows and macOS.

@pipboy96

Copy link
Copy Markdown
Contributor Author

@J0WI Conflict resolved.

@J0WI J0WI removed the conflict label Mar 14, 2019
@pipboy96 pipboy96 changed the title Fix two errors in Firefox by replacing sync XHR Fix two JS errors by replacing sync XHR Apr 6, 2019
@pipboy96 pipboy96 added the chrome label Apr 6, 2019
@pipboy96

pipboy96 commented Apr 6, 2019

Copy link
Copy Markdown
Contributor Author

Closing for now.

@pipboy96 pipboy96 closed this Apr 6, 2019
@pipboy96
pipboy96 deleted the patch-11 branch August 7, 2019 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants